Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker #6

Merged
merged 4 commits into from
Jun 26, 2018
Merged

Docker #6

merged 4 commits into from
Jun 26, 2018

Conversation

marcomorain
Copy link
Contributor

🏓

Copy link
Contributor

@zzak zzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went ahead and rebased cebfbae out from #5 that was grouped in this branch?

Otherwise, I think this is good to merge once the job is passing.

@codecov-io
Copy link

Codecov Report

Merging #6 into master will decrease coverage by 0.85%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   35.65%   34.79%   -0.86%     
==========================================
  Files           9        9              
  Lines         446      457      +11     
==========================================
  Hits          159      159              
- Misses        271      282      +11     
  Partials       16       16
Impacted Files Coverage Δ
cmd/orb.go 20.25% <0%> (-1.09%) ⬇️
cmd/config.go 4.49% <0%> (-0.39%) ⬇️
cmd/root.go 76% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8f6faf...79bf3a8. Read the comment docs.

@marcomorain marcomorain merged commit 11790ed into master Jun 26, 2018
@marcomorain marcomorain deleted the docker branch June 26, 2018 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants