feat: add verbose flag for pipeline values #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyardley
commented
Mar 8, 2023
wyardley
force-pushed
the
wyardley/860
branch
2 times, most recently
from
08875a4 to
3aa6bb4
Compare
wyardley
changed the title
|
@elliotforbes now that it's updated, are you able to review this and / or bug someone who can? |
Let me ping the team, I've got another PR for this repo I'm looking to get out first which will likely cause conflicts. |
elliotforbes
approved these changes
Mar 21, 2023
- Add a `-v` / `--verbose` flag to enable verbose output - Print the config values one line at a time, and add newlines - Write to stderr so that outputting to a file won't generate invalid YAML when writing files to stdout Fixes CircleCI-Public#860
|
@elliotforbes rebased |
|
@wyardley - feel free to merge when ready, I'll cut a new release branch and get this out today hopefully! |
|
@elliotforbes i think someone with commit access will have to merge. |
15 tasks
wyardley
added a commit
to wyardley/circleci-cli
that referenced
this pull request
Mar 30, 2023
Reintroduces the output style introduced in CircleCI-Public#861 to resolve CircleCI-Public#860, but reverted in CircleCI-Public#884
7 tasks
wyardley
added a commit
to wyardley/circleci-cli
that referenced
this pull request
Apr 5, 2023
Resolve some issues from CircleCI-Public#861 and CircleCI-Public#896 - Suppress some whitespace when verbose output is not enabled - Write to stderr again - Use "%v" instead of "%s" so that "number" in pipeline values gets printed correctly - Sort values to provide stable output order for pipeline values
7 tasks
wyardley
added a commit
to wyardley/circleci-cli
that referenced
this pull request
Apr 5, 2023
Resolve some issues from CircleCI-Public#861 and CircleCI-Public#896 - Suppress some whitespace when verbose output is not enabled - Write to stderr again - Use "%v" instead of "%s" so that "number" in pipeline values gets printed correctly - Sort values to provide stable output order for pipeline values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
=========
Internal Checklist
Changes
=======
-v/--verboseflag to enable verbose outputRationale
The current output is not aesthetically pleasing, and is also hard to read / follow. Additionally, people may want a way to suppress this new behavior
@particleflux also pointed out in #860 that in the
circleci config processandcircleci config packcommands, this will actually generate invalid YAML.Fixes #860
Considerations
Happy to adjust the option name / invert the behavior to make things more consistent with options elsewhere in the program, or to tweak the formatting / output slightly. I think this is, while maybe not perfect, a big improvement.
Screenshots
Before
After