PIPE-3873 fixing type-casting issue #897
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI previously handled pipeline values as a map of strings to strings which was presumably to appease the formats expected by the unstable GraphQL server.
With the migration from this unstable GraphQL service to a direct HTTP call, this exposed this bug #895
I've added 2 commits to this PR - the first is a failing test case that replicates the issue the user was having and then the code change from
map[string]string
->map[string]interface{}
for the values which the enables the test case to pass and non-string values to be handled correctly.Checklist
=========
Internal Checklist
Changes
=======
Rationale
=========
What was the overarching product goal of this PR as well as any pertinent
history of changes
Considerations
==============
Why you made some of the technical decisions that you made, especially if the
reasoning is not immediately obvious
Screenshots
============
Before
Image or [gif](https://giphy.com/apps/giphycapture)After
Image or gif where change can be clearly seenHere are some helpful tips you can follow when submitting a pull request:
main
.make build
in the repository root.make test
).--debug
flag is often helpful for debugging HTTP client requests and responses.make lint
). Note: This requires Docker to run inside a local job.