Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIPE-3873 fixing type-casting issue #897

Merged
merged 3 commits into from
Mar 31, 2023

Conversation

elliotforbes
Copy link
Contributor

@elliotforbes elliotforbes commented Mar 31, 2023

The CLI previously handled pipeline values as a map of strings to strings which was presumably to appease the formats expected by the unstable GraphQL server.

With the migration from this unstable GraphQL service to a direct HTTP call, this exposed this bug #895

I've added 2 commits to this PR - the first is a failing test case that replicates the issue the user was having and then the code change from map[string]string -> map[string]interface{} for the values which the enables the test case to pass and non-string values to be handled correctly.

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Internal Checklist

  • I am requesting a review from my own team as well as the owning team
  • I have a plan in place for the monitoring of the changes that I am making (this can include new monitors, logs to be aware of, etc...)

Changes

=======

Rationale

=========

What was the overarching product goal of this PR as well as any pertinent
history of changes

Considerations

==============

Why you made some of the technical decisions that you made, especially if the
reasoning is not immediately obvious

Screenshots

============

Before

Image or [gif](https://giphy.com/apps/giphycapture)

After

Image or gif where change can be clearly seen

Here are some helpful tips you can follow when submitting a pull request:

  1. Fork the repository and create your branch from main.
  2. Run make build in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (make test).
  5. The --debug flag is often helpful for debugging HTTP client requests and responses.
  6. Format your code with gofmt.
  7. Make sure your code lints (make lint). Note: This requires Docker to run inside a local job.

@elliotforbes elliotforbes requested a review from a team as a code owner March 31, 2023 09:32
@elliotforbes elliotforbes changed the title Pipe 3873 fixing type casting issue PIPE-3873 fixing type-casting issue Mar 31, 2023
@elliotforbes elliotforbes merged commit ea62439 into develop Mar 31, 2023
@elliotforbes elliotforbes deleted the pipe-3873-fixing-type-casting-issue branch March 31, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants