Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loop in install script #944

Closed

Conversation

christian-stephen
Copy link
Contributor

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Changes

=======

  • Fix the infinite loop in the install script by renaming the install function in the script to install_circleci, so that it no longer has a name collision with the system's install command

Rationale

=========

Per this issue and comment, a recently merged PR appears to have introduced an infinite loop in the install script because of a name collision with the install function and the system's install command. When piping the script into bash, it loops indefinitely as the install function recursively calls itself:

Starting installation.
Installing CircleCI CLI v0.1.26646
Installing to /usr/local/bin
Starting installation.
Installing CircleCI CLI v0.1.26646
Installing to /usr/local/bin
Starting installation.
Installing CircleCI CLI v0.1.26646
^C⏎

Considerations

==============

N/A

Screenshots

============

N/A

@christian-stephen
Copy link
Contributor Author

Closing in favour of #943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant