Fix infinite loop in install script #944
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
=========
Changes
=======
install
function in the script toinstall_circleci
, so that it no longer has a name collision with the system'sinstall
commandRationale
=========
Per this issue and comment, a recently merged PR appears to have introduced an infinite loop in the install script because of a name collision with the
install
function and the system'sinstall
command. When piping the script intobash
, it loops indefinitely as theinstall
function recursively calls itself:Considerations
==============
N/A
Screenshots
============
N/A