Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure temporary directory for local execute #967

Merged
merged 14 commits into from
Dec 5, 2023

Conversation

loderunner
Copy link
Contributor

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Internal Checklist

  • I am requesting a review from my own team as well as the owning team
  • I have a plan in place for the monitoring of the changes that I am making (this can include new monitors, logs to be aware of, etc...)

Changes

During circleci local execute, make it possible to configure temporary directory to store config file.

Rationale

This was needed to support alternative (aka "not Docker") container distributions on macOS, particularly lima-based distributions, such as colima or Rancher Desktop, that do not support mounting /tmp (or other "system paths") to their Linux VM.

Considerations

@loderunner loderunner requested a review from a team as a code owner July 18, 2023 17:10
@loderunner loderunner self-assigned this Jul 18, 2023
@loderunner loderunner force-pushed the DEVEX-1190-add-temp-directory-to-settings-file branch from 7d70984 to 431ba76 Compare July 19, 2023 14:31
@loderunner loderunner marked this pull request as draft July 24, 2023 08:48
@rolandcrosby-columntax
Copy link

Thanks for making this PR -- it seems to resolve the "/tmp/local_build_config.yml: is a directory" issue with Rancher Desktop.

@brunkb
Copy link

brunkb commented Aug 18, 2023

Would like to see this change go in, or if someone could point me to the workaround. I'm on Intel Mac and Rancher Desktop.

@mjftw
Copy link

mjftw commented Nov 19, 2023

+1

this would solve issues I see related to #716

@loderunner loderunner force-pushed the DEVEX-1190-add-temp-directory-to-settings-file branch from 6903815 to b9e1e9f Compare December 4, 2023 16:19
@loderunner loderunner marked this pull request as ready for review December 5, 2023 11:03
Copy link
Contributor

@JulesFaucherre JulesFaucherre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad this finally gets out!

@loderunner loderunner merged commit c5392c3 into develop Dec 5, 2023
1 check passed
@loderunner loderunner deleted the DEVEX-1190-add-temp-directory-to-settings-file branch December 5, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants