[SNC-392] compile support for policy test command #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmdm
changed the title
sagar-connect
approved these changes
Jul 27, 2023
| @@ -490,6 +494,44 @@ This group of commands allows the management of polices to be verified against b | |||
| runnerOpts := tester.RunnerOptions{ | |||
| Path: args[0], | |||
| Include: include, | |||
| Compile: func(data []byte, pipelineValues map[string]any) ([]byte, error) { | |||
There was a problem hiding this comment.
feels like a good candidate for a separate function outside of command definition
| @@ -1330,13 +1331,31 @@ func TestTestRunner(t *testing.T) { | |||
| assert.Contains(t, s, "<?xml") | |||
| }, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Test suggestion:
compile: true, but owner-id isn't provided.
There was a problem hiding this comment.
That is the current test case
There was a problem hiding this comment.
My understanding is if compilation is required, but owner-id isn't provided, it should fail in some way.
But the expectation is pass in this test?
There was a problem hiding this comment.
Owner-ID is only required if you need to pull a private orb
rooneyshuman
approved these changes
Jul 27, 2023
JulesFaucherre
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
=========
Internal Checklist
Changes
=======
circleci policy testcommand by adding the policy-agent compile functionRationale
=========
To provide a better testing experience of CircleCI Config Policies, we needed to update the policy-agent that understood the compile and pipeline_parameters directive, and provide a compilation function for it to use.