Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added orb imports #107

Merged
merged 6 commits into from
Jun 23, 2022
Merged

feat: added orb imports #107

merged 6 commits into from
Jun 23, 2022

Conversation

Jaryt
Copy link
Contributor

@Jaryt Jaryt commented Jun 22, 2022

Added base system for orb imports

CI changes:
split tests, and override codecov threshold since tests are split. Codecov upload handles it afterwards.

@ghost
Copy link

ghost commented Jun 22, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

Copy link

@brivu brivu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #107 (042d933) into main (d3255c8) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #107   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          103       106    +3     
  Lines          983      1024   +41     
  Branches        87        88    +1     
=========================================
+ Hits           983      1024   +41     
Impacted Files Coverage Δ
...nents/Commands/exports/Reusable/ReusableCommand.ts 100.00% <ø> (ø)
src/lib/Components/Workflow/exports/WorkflowJob.ts 100.00% <ø> (ø)
src/lib/Config/exports/Validator.ts 100.00% <ø> (ø)
src/lib/Config/types/index.ts 100.00% <ø> (ø)
src/index.ts 100.00% <100.00%> (ø)
...lib/Components/Executors/exports/ReusedExecutor.ts 100.00% <100.00%> (ø)
src/lib/Config/exports/Mapping.ts 100.00% <100.00%> (ø)
src/lib/Config/index.ts 100.00% <100.00%> (ø)
src/lib/Orb/exports/OrbImport.ts 100.00% <100.00%> (ø)
src/lib/Orb/exports/OrbRef.ts 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3255c8...042d933. Read the comment docs.

@Jaryt Jaryt merged commit b4d790a into main Jun 23, 2022
@Jaryt Jaryt deleted the feat/orb-imports branch June 23, 2022 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants