Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Generable Flatten Option #108

Merged
merged 1 commit into from
Jun 29, 2022
Merged

feat: Generable Flatten Option #108

merged 1 commit into from
Jun 29, 2022

Conversation

Jaryt
Copy link
Contributor

@Jaryt Jaryt commented Jun 29, 2022

  • Removed stale 'context' feature
  • Implemented flatten option

@ghost
Copy link

ghost commented Jun 29, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #108 (dab2058) into main (b4d790a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #108   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          106       106           
  Lines         1024      1022    -2     
  Branches        88        87    -1     
=========================================
- Hits          1024      1022    -2     
Impacted Files Coverage Δ
...b/Components/Executors/exports/ReusableExecutor.ts 100.00% <ø> (ø)
src/lib/Components/Job/exports/ParameterizedJob.ts 100.00% <ø> (ø)
src/lib/Components/Logic/exports/Condition.ts 100.00% <ø> (ø)
...Components/Workflow/exports/WorkflowJobAbstract.ts 100.00% <ø> (ø)
...lib/Components/Executors/exports/ReusedExecutor.ts 100.00% <100.00%> (ø)
src/lib/Components/Job/index.ts 100.00% <100.00%> (ø)
src/lib/Components/Logic/exports/When.ts 100.00% <100.00%> (ø)
src/lib/Components/Logic/exports/conditions/And.ts 100.00% <100.00%> (ø)
src/lib/Components/Logic/exports/conditions/Not.ts 100.00% <100.00%> (ø)
src/lib/Components/Logic/exports/conditions/Or.ts 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4d790a...dab2058. Read the comment docs.

Copy link
Contributor

@jliby jliby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jaryt Jaryt merged commit 0d4a872 into main Jun 29, 2022
@Jaryt Jaryt deleted the feat/flatten-option branch June 29, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants