Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make orb component imports empty if no manifest provided #121

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

Jaryt
Copy link
Contributor

@Jaryt Jaryt commented Aug 15, 2022

No description provided.

@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #121 (799ae65) into main (5b4bea6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files          61       61           
  Lines         619      623    +4     
  Branches       46       47    +1     
=======================================
+ Hits          617      621    +4     
  Misses          1        1           
  Partials        1        1           
Impacted Files Coverage Δ
src/lib/Config/types/index.ts 100.00% <ø> (ø)
src/lib/Orb/exports/OrbImport.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghost
Copy link

ghost commented Aug 15, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@KyleTryon
Copy link
Contributor

KyleTryon commented Aug 16, 2022

@Jaryt ideally break out the husky change into a new commit, doesnt need to be a new PR

@Jaryt
Copy link
Contributor Author

Jaryt commented Aug 16, 2022

@Jaryt ideally break out the husky change into a new commit, doesnt need to be a new PR

It is in it's own commit

@Jaryt Jaryt merged commit 9bd2517 into main Aug 16, 2022
@Jaryt Jaryt deleted the fix/orb-imports-empty branch August 16, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants