-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#154): Disable aliasDuplicateObjects by default #155
feat(#154): Disable aliasDuplicateObjects by default #155
Conversation
Anchors are created by default to deduplicate parts of the generated YAML, which makes it harder to read. Removing them makes pipelines more "human readable".
👇 Click on the image for a new way to code review
Legend |
I was just noticing this yesterday. We used to have this off. I think when we pulled the parser out something changed. Thank you for this! I was semi-considering leaving it, as it makes the config smaller but i think less users are expecting to see it. Thank you for the addition! Running tests now |
Codecov ReportBase: 97.58% // Head: 97.58% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
=======================================
Coverage 97.58% 97.58%
=======================================
Files 61 61
Lines 662 662
Branches 65 65
=======================================
Hits 646 646
Misses 5 5
Partials 11 11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Passed 👍 Going to merge this in now but we might hold off on a release for just a short while if this is non-critical, so that we can bundle a few more updates into the next feat release. Let us know if that's acceptable 👍. Thanks again! |
Not critical, just a more cosmetic thing. Thanks for merging! :) |
Anchors are created by default to deduplicate parts of the generated YAML, which makes it harder to read.
Removing them makes pipelines more "human readable".
This closes #154.