Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rename writeFile path #172

Merged
merged 3 commits into from
Feb 9, 2023
Merged

docs: rename writeFile path #172

merged 3 commits into from
Feb 9, 2023

Conversation

TatsuyaYamamoto
Copy link
Contributor

I read example doc and probably found a mistake.

configuration_path: ./dynamicConfig.yml
https://github.com/CircleCI-Public/circleci-config-sdk-ts/blob/main/sample/01-dynamic-workflow-javascript/.circleci/config.yml

So, I think myConfig.writeFile should received dynamicConfig.yml

@ghost
Copy link

ghost commented Dec 16, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

Copy link
Contributor

@KyleTryon KyleTryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 96.16% // Head: 96.16% // No change to project coverage 👍

Coverage data is based on head (8051d7e) compared to base (00ddfb1).
Patch has no changes to coverable lines.

❗ Current head 8051d7e differs from pull request most recent head ff2b295. Consider uploading reports for the commit ff2b295 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #172   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files          62       62           
  Lines         678      678           
  Branches       69       69           
=======================================
  Hits          652      652           
  Misses         11       11           
  Partials       15       15           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KyleTryon KyleTryon merged commit 9571882 into CircleCI-Public:main Feb 9, 2023
@TatsuyaYamamoto TatsuyaYamamoto deleted the patch-3 branch May 7, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants