Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Call generate on custom step parameters #192

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JohnGrisham
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our contributor guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Documentation has been added or updated where needed.

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

more details

What issues are resolved by this PR?

Describe the new behavior.

Description
When passing custom step parameters to a job within a workflow the commands get generated incorrectly. For example when trying to pass commands coming from an orb, like so:

pre_lint: [composer, 'test', typecheck],

Before the change:

- mindful/lint-and-unit-test:
          pre_lint:
            - name: mindful/composer
              parameters:
                environment_id: << pipeline.parameters.deployment_type >>
                instance_id: << pipeline.parameters.instance_type >>
            - test
            - parameters:
                name: Typecheck
                command: yarn run typecheck

After the change:

- mindful/lint-and-unit-test:
          pre_lint:
            - mindful/composer:
                environment_id: << pipeline.parameters.deployment_type >>
                instance_id: << pipeline.parameters.instance_type >>
            - test
            - run:
                name: Typecheck
                command: yarn run typecheck

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

More information (optional)

The linked issue is more of a general description but I believe it applies here too. If a new issue needs to be opened I can do that as well.

@JohnGrisham
Copy link
Author

@bear Tagging you since you approved the last couple of PRs. I don't know who needs to look at this, so if someone else needs to be tagged please tag them instead.

@JohnGrisham
Copy link
Author

@brivu @KyleTryon I'm not sure who to tag on this or what the state of the project is. Please redirect me to a project maintainer if I've tagged the wrong people.

@KyleTryon
Copy link
Contributor

We are no longer a part of the organization. Please reach out to support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants