Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter skip_install to gcp-cli/setup #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

w1mvy
Copy link

@w1mvy w1mvy commented Jan 20, 2023

Checklist

  • All new jobs, commands, executors, parameters have descriptions
  • Examples have been added for any significant new features
  • README has been updated, if necessary

Motivation, issues

Hi. This orb has always helped me!!

When orbs was upgraded from v2 to v3, it now calls the install command inside gcp-cli/setup as well, which causes failure uninstall step when use an image which gcloud is installed. (We used image based on google/cloud-sdk:alpine, work around it by installing the sudo command, but we don't want to reinstall itself).

It is helpful that gcp-cli/install runs automatically, but it would be more convenient to have the ability to skip.

Description

Add parameter skip_install in gcp-cli/setup command

@andrelegault
Copy link

andrelegault commented Mar 19, 2024

Skipping the installation of the sdk makes the most sense to me given the fact that some installations are done using package managers which won't work with this orb's usage of gcloud components install (docs) to reinstall components. A current workaround for this is to leverage #77 and pin a version lower than what's currently installed I misunderstood the PR, the uninstall is only skipped if you have a version more recent than the latest version the orb finds. That being said, having the option to explicitly skip the install would be nice.

@david-montano-circleci david-montano-circleci self-assigned this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants