Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: version in example #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: version in example #67

wants to merge 1 commit into from

Conversation

hun-ho
Copy link

@hun-ho hun-ho commented Jan 24, 2023

Checklist

  • All new jobs, commands, executors, parameters have descriptions
  • Examples have been added for any significant new features
  • README has been updated, if necessary

Motivation, issues

I wanted to copy the example as is and try the orb. However, gcp-cli/setup step did not work as the version in the example is on v2.

Description

I updated the example to v3 and it worked.

@hun-ho hun-ho requested a review from a team as a code owner January 24, 2023 11:49
@kpchoy
Copy link

kpchoy commented Aug 11, 2023

+1 please merge, would save some headache in copy pasting

@wyardley wyardley mentioned this pull request Aug 11, 2023
Closed
@david-montano-circleci david-montano-circleci self-assigned this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyardley wyardley wyardley approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@david-montano-circleci david-montano-circleci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hun-ho @kpchoy @wyardley @david-montano-circleci