Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPM Cache Keys #129

Merged

Conversation

nicklozon
Copy link
Contributor

@nicklozon nicklozon commented Mar 3, 2022

SEMVER Update Type:

  • Major
  • Minor
  • Patch

Description:

Motivation:

Cache key is not consistent between retrieval and saving jobs for npm - all save_cache steps are not respecting the cache-only-lockfile parameter.

Closes Issues:

Checklist:

  • All new jobs, commands, executors, parameters have descriptions.
  • Usage Example version numbers have been updated.
  • Changelog has been updated.

@gavinsharp
Copy link

I have a similar PR up at #122.

@Jaryt Jaryt changed the base branch from master to feat/respect-yarnrc-ver March 14, 2022 18:53
@Jaryt Jaryt changed the base branch from feat/respect-yarnrc-ver to master March 14, 2022 18:53
@Jaryt Jaryt changed the base branch from master to fix/yarn-and-cache March 14, 2022 19:05
@Jaryt Jaryt merged commit 905cccb into CircleCI-Public:fix/yarn-and-cache Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants