Support events without a payload #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, 'on: schedule' does not have a payload[1], which results in
an error when attempting to use this action:
TypeError: Cannot read property 'url' of undefined
This commit updates the code to use the `repo` attribute instead
of parsing out the repo org/name from the repo URL.
1. https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule
``` npm run lint && npm run format && npm run build ``` Added this as a separate commit, as I don't know anything about npm packages, and it's not clear if all of the package list changes are desirable.
It may be preferable to set a v1 link and keep that updated to point to the latest release. Also mentioned in PR CircleCI-Public#11: CircleCI-Public#11 (comment)
|
Here is the error message from a failed run before this changeset was applied: Here is the associated workflow config file: |
omxela
pushed a commit
to mo-work/trigger-circleci-pipeline-action
that referenced
this pull request
Oct 9, 2022
* support events that don't have a payload
For example, 'on: schedule' does not have a payload[1], which results in
an error when attempting to use this action:
TypeError: Cannot read property 'url' of undefined
This commit updates the code to use the `repo` attribute instead
of parsing out the repo org/name from the repo URL.
1. https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule
* prepare build
```
npm run lint && npm run format && npm run build
```
Added this as a separate commit, as I don't know anything about npm
packages, and it's not clear if all of the package list changes are
desirable.
* README: unify version
It may be preferable to set a v1 link and keep that updated to point to
the latest release.
Also mentioned in PR CircleCI-Public#11:
CircleCI-Public#11 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code does not support the
scheduleevent type because it does not have a request payload. This changeset updates the code to avoid requiring a payload for parsing out the repo owner and name.In preparation for testing, I ran
npm run lint && npm run format && npm run buildwhich was in.husky/pre-commitand committed the results, but it's not clear to me if the package updates are dependent on my local (and likely broken) environment. It's a separate commit (186ad68) so it can more easily be removed from the PR if necessary.My testing was limited to the
scheduleandworkflow_dispatch(manual) events, both of which worked with this update. The schedule event does not have a payload, but the workflow_displatch does.Hope this helps!