fix: pr ref to branch head #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
growse
referenced
this pull request
in owntracks/android
Dec 16, 2022
…0.6 (#1348) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [CircleCI-Public/trigger-circleci-pipeline-action](https://togithub.com/CircleCI-Public/trigger-circleci-pipeline-action) | action | patch | `v1.0.5` -> `v1.0.6` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the logs for more information. --- ### Release Notes <details> <summary>CircleCI-Public/trigger-circleci-pipeline-action</summary> ### [`v1.0.6`](https://togithub.com/CircleCI-Public/trigger-circleci-pipeline-action/releases/tag/v1.0.6): - Checkout HEAD on PR branches [Compare Source](https://togithub.com/CircleCI-Public/trigger-circleci-pipeline-action/compare/v1.0.5...v1.0.6) #### What's Changed - docs: Move when clause under workflow declaration—not workflows by [@​mbigras](https://togithub.com/mbigras) in [https://github.com/CircleCI-Public/trigger-circleci-pipeline-action/pull/19](https://togithub.com/CircleCI-Public/trigger-circleci-pipeline-action/pull/19) - fix: move `when` block to under workflow defn by [@​kelvintaywl](https://togithub.com/kelvintaywl) in [https://github.com/CircleCI-Public/trigger-circleci-pipeline-action/pull/35](https://togithub.com/CircleCI-Public/trigger-circleci-pipeline-action/pull/35) - fix: pr ref to branch head by [@​KyleTryon](https://togithub.com/KyleTryon) in [https://github.com/CircleCI-Public/trigger-circleci-pipeline-action/pull/37](https://togithub.com/CircleCI-Public/trigger-circleci-pipeline-action/pull/37) #### New Contributors - [@​mbigras](https://togithub.com/mbigras) made their first contribution in [https://github.com/CircleCI-Public/trigger-circleci-pipeline-action/pull/19](https://togithub.com/CircleCI-Public/trigger-circleci-pipeline-action/pull/19) - [@​kelvintaywl](https://togithub.com/kelvintaywl) made their first contribution in [https://github.com/CircleCI-Public/trigger-circleci-pipeline-action/pull/35](https://togithub.com/CircleCI-Public/trigger-circleci-pipeline-action/pull/35) **Full Changelog**: CircleCI-Public/trigger-circleci-pipeline-action@v1.0.5...v1.0.6 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/owntracks/android). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC41NC4yIiwidXBkYXRlZEluVmVyIjoiMzQuNTQuMiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
joelmccracken
pushed a commit
to freckle/trigger-circleci-pipeline-action
that referenced
this pull request
Dec 21, 2022
* fix: update the ref for PRs to use the branch head * chore: build latest version
joelmccracken
added a commit
to freckle/trigger-circleci-pipeline-action
that referenced
this pull request
Jan 3, 2023
* send commit in parameters * docs: move `when` block to under workflow defn (CircleCI-Public#35) * fix: pr ref to branch head (CircleCI-Public#37) * fix: update the ref for PRs to use the branch head * chore: build latest version * fix: upgrade @actions/core from 1.6.0 to 1.10.0 (CircleCI-Public#38) Snyk has created this PR to upgrade @actions/core from 1.6.0 to 1.10.0. See this package in npm: https://www.npmjs.com/package/@actions/core See this project in Snyk: https://app.snyk.io/org/circleci-public/project/8492d229-17c6-4b64-b6e9-32a63d0ebceb?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <snyk-bot@snyk.io> * fix: upgrade axios from 0.24.0 to 0.27.2 (CircleCI-Public#39) Snyk has created this PR to upgrade axios from 0.24.0 to 0.27.2. See this package in npm: https://www.npmjs.com/package/axios See this project in Snyk: https://app.snyk.io/org/circleci-public/project/8492d229-17c6-4b64-b6e9-32a63d0ebceb?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <snyk-bot@snyk.io> * fix: upgrade @actions/github from 5.0.0 to 5.1.1 (CircleCI-Public#40) Snyk has created this PR to upgrade @actions/github from 5.0.0 to 5.1.1. See this package in npm: https://www.npmjs.com/package/@actions/github See this project in Snyk: https://app.snyk.io/org/circleci-public/project/8492d229-17c6-4b64-b6e9-32a63d0ebceb?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Kyle a.k.a. TechSquidTV <33272306+KyleTryon@users.noreply.github.com> * Rename package path to freckle * restyle * send branch as tag instead of commit * node 18 isn't supported yet * tweaks * debugging * i see, this is what I needed to do to actually make changes * a little bit of debugging * should actually send the real branch name * you cant fix stupid * go back to previous method of getting branch * include the pr ref as a separate parameter * go back, I think this may fix what i'm seeing? * use this since I have it Co-authored-by: Kelvin Tay <kelvintaywl@gmail.com> Co-authored-by: Kyle a.k.a. TechSquidTV <33272306+KyleTryon@users.noreply.github.com> Co-authored-by: circleci-secops <59066257+circleci-secops@users.noreply.github.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Joris Buchou <joris.buchou@gmail.com>
whatisdot
pushed a commit
to snapsheet/trigger-circleci-pipeline-action
that referenced
this pull request
Mar 21, 2023
](https://renovatebot.com){kind=link}
* fix: update the ref for PRs to use the branch head * chore: build latest version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aims to resolve #36
I was able to determine the issue was, the ref sent by GitHub is to a merge commit which has no parent. CircleCI attempts to check this out by the branch and then fails. This change instead pulls the head of the pull request.
Verification: https://app.circleci.com/pipelines/github/KyleTryon/CircleCI-Metadata-Build?branch=pull%2F9%2Fhead