Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: typescript optimized #51

Merged
merged 4 commits into from
Mar 29, 2023
Merged

refactor: typescript optimized #51

merged 4 commits into from
Mar 29, 2023

Conversation

KyleTryon
Copy link
Contributor

@KyleTryon KyleTryon commented Mar 28, 2023 •
edited
Loading

This refactors the project to build with typescript and is not intended to have any functional changes. Some minor optimizations were made as well as a fix to the husky pre-commit hook to ensure linting and building takes place and is commited.

@KyleTryon KyleTryon mentioned this pull request Mar 28, 2023
Closed
1 task
whatisdot
whatisdot reviewed Mar 28, 2023
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
whatisdot
whatisdot reviewed Mar 29, 2023
View reviewed changes
.husky/pre-commit Outdated Show resolved Hide resolved
whatisdot
whatisdot approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@whatisdot whatisdot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we want to address the hostname bug in a separate PR, this branch works as expected with that known issue. Build and lint work as expected 👍

EDIT: Just reran my deploy using this branch, and can confirm this fixes the issue. Thank you!

@rsylvian rsylvian self-requested a review March 29, 2023 21:43
rsylvian
rsylvian approved these changes Mar 29, 2023
View reviewed changes
Copy link

@rsylvian rsylvian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@KyleTryon KyleTryon merged commit e529ce0 into main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whatisdot whatisdot whatisdot approved these changes

@rsylvian rsylvian rsylvian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KyleTryon @whatisdot @rsylvian