Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value for databaseSource constructor param #112

Merged
merged 5 commits into from
May 12, 2022

Conversation

llunaCreixent
Copy link
Member

Closes #111

@llunaCreixent llunaCreixent requested a review from JacqueGM as a code owner May 12, 2022 09:45
@llunaCreixent llunaCreixent requested review from mikozet and louilinn May 12, 2022 09:45
@llunaCreixent llunaCreixent changed the title Add defaultvalue for databaseSource constructor param Add default value for databaseSource constructor param May 12, 2022
@llunaCreixent
Copy link
Member Author

test PASS with:

  • api v1.4.0
  • relayer v4.1.11
  • subgraph v1.3.0

mikozet
mikozet previously approved these changes May 12, 2022
@llunaCreixent
Copy link
Member Author

llunaCreixent commented May 12, 2022

test PASS again with:

  • api v1.4.0
  • relayer v4.1.11
  • subgraph v1.3.0

@llunaCreixent llunaCreixent requested a review from mikozet May 12, 2022 10:39
@llunaCreixent llunaCreixent merged commit d110660 into main May 12, 2022
@llunaCreixent llunaCreixent deleted the default-constructor-param branch May 12, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

databaseSource in the Core constructor should be optional and have a default value
3 participants