Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added synchronous counter interactive example #128

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added synchronous counter interactive example #128

wants to merge 2 commits into from

Conversation

criticic
Copy link
Contributor

@criticic criticic commented Dec 14, 2019 •
edited
Loading

@criticic criticic mentioned this pull request Dec 14, 2019
Closed
@criticic
Copy link
Contributor Author

@sal2701 @PragatiVerma18 @sakshi1499 Please review.

@Ananthavijay
Copy link
Contributor

Ananthavijay commented Dec 14, 2019 •
edited
Loading

@fluctix I think you can also fix the broken image under Synchronous counters ( Image : At the end of file )

@sakshi1499
Copy link

@fluctix It looks good to me. @Ananthavijay which image are you talking about can you attach a screenshot? I can't see any broken image in my fork

@sakshi1499
Copy link

@PragatiVerma18 @sal2701 please look at it once?

@Ananthavijay
Copy link
Contributor

@sakshi1499 This is the one I am talking about.

Screenshot (103)

@Ananthavijay
Copy link
Contributor

@sakshi1499 check it here : https://github.com/CircuitVerse/Interactive-Book/blob/master/docs/counter.md

@sakshi1499
Copy link

Yes I have seen. The image is broken on Github .md page, its working fine on the website. Please edit that too @fluctix

sal2701
sal2701 suggested changes Dec 14, 2019
View reviewed changes
Copy link
Member

@sal2701 sal2701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fluctix One more small detail, can you just rename the circuit appropriately. Main is written on the top left, please change it.

@sal2701
Copy link
Member

sal2701 commented Dec 14, 2019

@sakshi1499 I think we should show 2 outputs, Qa and Qb as it'll better demonstrate the 2 Bit Counter. A single output here is confusing. What say?

@criticic
Copy link
Contributor Author

Updated the Markdown file to point to the correct location of the Image(as requested by @Ananthavijay ) and also as @sal2701 suggested, I renamed the circuit from 'main' to 'Synchronous Counter' , and added one more output(ie. Qa) for better understanding.
Screenshots:
Screenshot1
Screenshot2

@criticic
Copy link
Contributor Author

@sakshi1499 @sal2701 Please review.

@PragatiVerma18
Copy link
Member

PragatiVerma18 commented Dec 15, 2019 •
edited
Loading

Looks good to me!! Great work @fluctix 😃 Please review @sakshi1499 @sal2701 and let's not delay this further.

@sakshi1499
Copy link

Great work!. @sal2701 that was a good suggestion.

@sakshi1499
Copy link

@sal2701 Please look at it if you find no issues please approve it?

@criticic
Copy link
Contributor Author

New changes have brought merge conflicts....

@YashKumarVerma YashKumarVerma added the inactive inactive for a significant peiod, would be closed in near future label May 15, 2020
@Shivansh2407
Copy link
Member

@criticic can you please fix the merge conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sal2701 sal2701 sal2701 requested changes

@sakshi1499 sakshi1499 sakshi1499 approved these changes

@PragatiVerma18 PragatiVerma18 PragatiVerma18 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
inactive inactive for a significant peiod, would be closed in near future
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@criticic @Ananthavijay @sakshi1499 @sal2701 @PragatiVerma18 @Shivansh2407 @YashKumarVerma