Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOR and XOR Descriptions Fixed #162

Merged
merged 15 commits into from
Jan 18, 2020
Merged

NOR and XOR Descriptions Fixed #162

merged 15 commits into from
Jan 18, 2020

Conversation

NumberC
Copy link
Contributor

@NumberC NumberC commented Dec 28, 2019

Fixes #161
NOR
XOR

@NumberC
Copy link
Contributor Author

NumberC commented Dec 28, 2019

@tachyons @ankitkataria Can you please merge this?

@NumberC
Copy link
Contributor Author

NumberC commented Jan 4, 2020

Done

@aayushgupta05
Copy link
Member

Remove the unrelated changes @NumberC . No need to change jquery assests with cdn and bypass netlify error.

@NumberC
Copy link
Contributor Author

NumberC commented Jan 9, 2020

@Aayush-05 Is this better?

@aayushgupta05
Copy link
Member

Remove the change regarding the jquery version as well.

@NumberC
Copy link
Contributor Author

NumberC commented Jan 15, 2020

@Aayush-05 Sorry about that. This should be better

tachyons
tachyons reviewed Jan 17, 2020
View reviewed changes
_includes/fsm.html Outdated Show resolved Hide resolved
tachyons
tachyons reviewed Jan 17, 2020
View reviewed changes
assets/js/module.js Outdated Show resolved Hide resolved
@NumberC
Copy link
Contributor Author

NumberC commented Jan 17, 2020

Do you think this is better?

@aayushgupta05
Copy link
Member

Looks good to me @NumberC . We can merge this now @tachyons

@tachyons tachyons merged commit 1e5a1df into CircuitVerse:master Jan 18, 2020
mohit-003 pushed a commit to mohit-003/Interactive-Book that referenced this pull request Jan 25, 2020
@NumberC @mohit-003
NOR and XOR Descriptions Fixed (CircuitVerse#162)
a7594cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tachyons tachyons tachyons left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect NOR and XOR Descriptions
3 participants
@NumberC @aayushgupta05 @tachyons