Remove kmap layout and instead use default layout #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating repo
The kmap layout is removed, and the default layout is used instead of it in Intractive Karnaugh Map page, and some dark-mode issues of the same page are resolved
|
@tachyons Please review. |
|
This looks good, but I am not very sure if we are currently switching to a central default layout for all pages. Also I will have to check that it is not affecting other pages. |
|
I checked all other pages and only the K-map page used kmap layout and all other pages are using the default layout. |
YashKumarVerma
suggested changes
May 20, 2020
|
Resolved in #297 via #295 . @YashKumarVerma can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #223
and #236The kmap layout is removed, and the default layout is used instead of it in Intractive Karnaugh Map page, and some dark-mode issues of the same page are resolved.
Before:
After:
Light-mode is not affected much
