Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: simplify code contributions by fully automating the dev setup with Gitpod #374

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nisarhassan12
Copy link

@nisarhassan12 nisarhassan12 commented May 27, 2020

Fixes #78

This is how it looks:

image

You can give it a try on my fork of the repo via the following link:

https://gitpod.io/#https://github.com/nisarhassan12/Interactive-Book/

As I pointed out in #78 (comment) that styles were not showing up.

Many Thanks to @Kreyren he was able to fix this via prefixing the href value with {{ site.url }}:

<link rel="stylesheet" href="{{ "{{ site.url }}/assets/css/just-the-docs.css" | absolute_url }}">

There are still many things remaining i.e the links in the sidebar does not work so I'll make those changes soon.

@Kreyren
Copy link

Kreyren commented May 27, 2020

FWIW I have a fix staged in https://gitpod.io#snapshot/d3a9516c-4be3-47b2-81dc-df4020ff4f57, but it's blocked by gitpod-io/gitpod#1553

Investigating if we can implement this in nice way, worst case scenario is firefox in novnc atm that i want to avoid.

@nisarhassan12 nisarhassan12 marked this pull request as draft May 27, 2020 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup Gitpod for this project
2 participants