Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix - failed to load widget/error widget #134

Merged
merged 2 commits into from
Sep 11, 2021
Merged

fix - failed to load widget/error widget #134

merged 2 commits into from
Sep 11, 2021

Conversation

roopak99
Copy link
Contributor

@roopak99 roopak99 commented Sep 9, 2021

Fixes #84

Describe the changes you have made in this PR - implemented a CVException widget that wraps and shows error (if occurs) during the loading of any widget according to ViewModel's Failure Response.

Screenshots of the changes (If any) -
WhatsApp Image 2021-09-10 at 1 38 10 AM

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

manjotsidhu
manjotsidhu approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@manjotsidhu manjotsidhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Though CVException is widget, the best place for it would be in ui/components.

@roopak99
Copy link
Contributor Author

Yes that would be a better place ,
+changed the directory of CVException to ui/components.

@manjotsidhu
Copy link
Member

It looks like CI is throwing errors while running flutter analyze (7 errors found). I think it's not due to the changes you made in this pull request. I am merging this PR, but I request you to make another PR for fixing the issues thrown by flutter analyze.

@manjotsidhu manjotsidhu merged commit d3fd49c into CircuitVerse:master Sep 11, 2021
@roopak99
Copy link
Contributor Author

CI is throwing error for the following features( accentColor, accentTextTheme and brighntness ) as they are deprecated and not advised to use. accentColor can be migrated using the new colorScheme feature but accentTextTheme and brightness are no longer used. Please guide me how should i proceed

@manjotsidhu
Copy link
Member

CI is throwing error for the following features( accentColor, accentTextTheme and brighntness ) as they are deprecated and not advised to use. accentColor can be migrated using the new colorScheme feature but accentTextTheme and brightness are no longer used. Please guide me how should i proceed

Even I will have to take a look. Kindly make an Issue of these CI errors, we will take them one by one in checklist.

manjotsidhu added a commit that referenced this pull request Oct 1, 2021
@manjotsidhu
Revert "fix: failed to load widget/error widget (#134)"
2e5452e 
This reverts commit d3fd49c.
manjotsidhu added a commit that referenced this pull request Oct 1, 2021
@manjotsidhu
Revert "fix: failed to load widget/error widget (#134)"
e53a025 
This reverts commit d3fd49c.
@manjotsidhu manjotsidhu mentioned this pull request Oct 1, 2021
Closed
manjotsidhu added a commit that referenced this pull request Oct 1, 2021
@manjotsidhu
Revert "fix: failed to load widget/error widget (#134)"
1f400a9 
This reverts commit d3fd49c.
@manjotsidhu manjotsidhu mentioned this pull request Oct 1, 2021
Merged
manjotsidhu added a commit that referenced this pull request Oct 3, 2021
@manjotsidhu @RakeshSeervi
fix: migrate to flutter 2.5 (#144)
7a1e5eb 
* fix: migrate to flutter 2.5

* Revert "fix: failed to load widget/error widget (#134)"

This reverts commit d3fd49c.

* fix: update kotlin version to 1.5.10

Signed-off-by: Manjot Sidhu <manjot.techie@gmail.com>

* fix: iOS build failure (#146)

* fix: format lib/ib_theme.dart

Co-authored-by: Rakesh Seervi <rakeshbseervi16@gmail.com>
@manjotsidhu manjotsidhu mentioned this pull request Oct 26, 2021
Closed
@manjotsidhu manjotsidhu mentioned this pull request Dec 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nitish145 Nitish145 Awaiting requested review from Nitish145

@manjotsidhu manjotsidhu Awaiting requested review from manjotsidhu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Failed to load/ Error widget
2 participants
@roopak99 @manjotsidhu