-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: migrate to flutter 2.5 #144
Conversation
This reverts commit d3fd49c.
Signed-off-by: Manjot Sidhu <manjot.techie@gmail.com>
the iOS build failed for me locally... I followed this answer and the build was successful. Does this help? |
Thanks @RakeshSeervi, could you make a Pull Request to |
sure, sending it right away |
lib/ib_theme.dart
Outdated
primaryIconTheme: Theme.of(context).primaryIconTheme.copyWith( | ||
color: Colors.white, | ||
), | ||
accentColor: IbTheme.primaryColor, | ||
appBarTheme: AppBarTheme( | ||
foregroundColor: Colors.white, backgroundColor: IbTheme.primaryColor), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't miss trailing commas please, leads to better formatting.
Fixes #135, Fixes #138
Migrate to Flutter 2.5
Changes :
photo_view
to0.12.0
for flutter 2.5 compatibility.