fix(lints): prefer_interpolation_to_compose_strings rule

[Neha62-lit]

Refer #149

Fix linter rule:

• prefer_interpolation_to_compose_strings

[Neha62-lit]

Hey @manjotsidhu, Review this PR!

[coveralls]

Pull Request Test Coverage Report for Build 1375325101

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 73.545%

---

Totals
Change from base Build 1351472917:	0.0%
Covered Lines:	3853
Relevant Lines:	5239

---

💛 - Coveralls

[manjotsidhu]

@Neha62-lit the changes look good, but I wonder the lint rule is not present in analysis_options file and analyser was not throwing warnings for them ?

[manjotsidhu]

We can merge this but I think we should only fix those rules which are disabled in analysis_options.yml

[Neha62-lit]

We can merge this but I think we should only fix those rules which are disabled in analysis_options.yml

Actually, I removed that rule from analysis_options.yaml file as you said before that the linter rules are true by default.

[manjotsidhu]

We can merge this but I think we should only fix those rules which are disabled in analysis_options.yml

Actually, I removed that rule from analysis_options.yaml file as you said before that the linter rules are true by default.

Yes but then why we didn't got any problems in CI checks ? Do you get any warnings if you discard the changes in your pull request ?

[Neha62-lit]

We can merge this but I think we should only fix those rules which are disabled in analysis_options.yml

There are still some linter rules that I haven't put in analysis_options.yml file and those rules are good for our code like prefer_interpolation_to_compose_strings, unnecessary_parenthesis etc. these some rules are good for our better understandable code.

[Neha62-lit]

We can merge this but I think we should only fix those rules which are disabled in analysis_options.yml

Actually, I removed that rule from analysis_options.yaml file as you said before that the linter rules are true by default.

Yes but then why we didn't got any problems in CI checks ? Do you get any warnings if you discard the changes in your pull request ?

No, I didn't get any warnings.

[manjotsidhu]

We can merge this but I think we should only fix those rules which are disabled in analysis_options.yml

Actually, I removed that rule from analysis_options.yaml file as you said before that the linter rules are true by default.

Yes but then why we didn't got any problems in CI checks ? Do you get any warnings if you discard the changes in your pull request ?

No, I didn't get any warnings.

Then why are we fixing something which is not flagged as an issue ?

[Neha62-lit]

We can merge this but I think we should only fix those rules which are disabled in analysis_options.yml

There are still some linter rules that I haven't put in analysis_options.yml file and those rules are good for our code like prefer_interpolation_to_compose_strings, unnecessary_parenthesis etc. these some rules are good for our better understandable code.

Okay, So basically there is no need of adding new linters rules as we are not getting any problems in CI checks.

[manjotsidhu]

We can merge this but I think we should only fix those rules which are disabled in analysis_options.yml

There are still some linter rules that I haven't put in analysis_options.yml file and those rules are good for our code like prefer_interpolation_to_compose_strings, unnecessary_parenthesis etc. these some rules are good for our better understandable code.

Okay, So basically there is no need of adding new linters rules as we are not getting any problems in CI checks.

Yes, we can only deal with lint fixes that are disabled in analysis_options.yml.

[Neha62-lit]

We can merge this but I think we should only fix those rules which are disabled in analysis_options.yml

There are still some linter rules that I haven't put in analysis_options.yml file and those rules are good for our code like prefer_interpolation_to_compose_strings, unnecessary_parenthesis etc. these some rules are good for our better understandable code.

Okay, So basically there is no need of adding new linters rules as we are not getting any problems in CI checks.

Yes, we can only deal with lint fixes that are disabled in analysis_options.yml.

Okay