Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and enable linter rules #149

Open
21 of 27 tasks
Neha62-lit opened this issue Oct 6, 2021 · 7 comments · Fixed by #152, #171 or #172
Open
21 of 27 tasks

Fix and enable linter rules #149

Neha62-lit opened this issue Oct 6, 2021 · 7 comments · Fixed by #152, #171 or #172
Labels
good first issue Good for newcomers Hacktoberfest

Comments

@Neha62-lit
Copy link
Contributor

Neha62-lit commented Oct 6, 2021 •
edited by aman-singh7
Loading

Is your feature request related to a problem? Please describe.

Yes, In flutter-lints dependency, there are so many linter rules that I disabled in PR #148

Now here are the checklists of the lint rules that are disabled (enabled rules are marked as checked) :

  • always_declare_return_types
  • avoid_print
  • avoid_unnecessary_containers
  • prefer_if_elements_to_conditional_expressions
  • prefer_const_constructors
  • prefer_const_declarations
  • unnecessary_string_interpolations
  • sized_box_for_whitespace
  • prefer_single_quotes
  • prefer_const_constructors_in_immutables
  • use_key_in_widget_constructors
  • prefer_function_declarations_over_variables
  • unnecessary_string_escapes
  • avoid_function_literals_in_foreach_calls
  • prefer_interpolation_to_compose_strings
  • unnecessary_parenthesis
  • sort_constructors_first
  • always_put_required_named_parameters_first
  • avoid_classes_with_only_static_members
  • avoid_redundant_argument_values
  • join_return_with_assignment
  • non_constant_identifier_names
  • constant_identifier_names
  • no_leading_underscores_for_local_identifiers
  • library_private_types_in_public_api
  • depend_on_referenced_packages
  • use_build_context_synchronously
    This rule will be intentionally be disabled since we use ALL_CAPS_WITH_UNDERSCORES for constants.
@Neha62-lit
Copy link
Contributor Author

Neha62-lit commented Oct 6, 2021 •
edited
Loading

Hey @manjotsidhu, Now I have to create a single PR of one rule at a time, right?

@manjotsidhu
Copy link
Member

Hey @manjotsidhu, Now I have to create a single PR of one rule at a time, right?

Yes

@manjotsidhu manjotsidhu changed the title Add all disable linter rules Fix and enable linter rules Oct 6, 2021
@manjotsidhu manjotsidhu mentioned this issue Oct 6, 2021
Merged
This was referenced Oct 7, 2021
Closed
Merged
@manjotsidhu manjotsidhu reopened this Oct 8, 2021
This was referenced Oct 8, 2021
Merged
Merged
@manjotsidhu manjotsidhu mentioned this issue Oct 10, 2021
Merged
This was referenced Oct 11, 2021
Merged
Merged
Merged
Merged
Merged
@Neha62-lit Neha62-lit mentioned this issue Oct 23, 2021
Merged
This was referenced Nov 17, 2021
Closed
Merged
@manjotsidhu manjotsidhu reopened this Nov 22, 2021
@aman-singh7
Copy link
Member

@manjotsidhu can I work on the remaining ones?

@aman-singh7 aman-singh7 mentioned this issue Nov 26, 2021
Merged
@manjotsidhu manjotsidhu reopened this Dec 4, 2021
@Aadeesh11
Copy link
Contributor

@manjotsidhu can i work on some of the remaining one?

Aadeesh11 added a commit to Aadeesh11/mobile-app that referenced this issue Dec 5, 2021
@Aadeesh11
Fixes: CircuitVerse#149
b5dcde1 
Enabled  non_constant_identifier_names
rule
Aadeesh11 added a commit to Aadeesh11/mobile-app that referenced this issue Dec 5, 2021
@Aadeesh11
rfrac: enabled avoid_redundant_argument_values rule.
7063cb9 
Fixes CircuitVerse#149
@Aadeesh11 Aadeesh11 mentioned this issue Dec 5, 2021
Closed
@devansh12b2
Copy link

@manjotsidhu can I work on some of the remaining.

@Aadeesh11 Aadeesh11 mentioned this issue Dec 15, 2021
Merged
manjotsidhu pushed a commit that referenced this issue Dec 24, 2021
@Aadeesh11
fix(lints): linter rules #149 (#179)
ba90d7a 
* rfrac: enabled unnecessary_parenthesis and avoid_redundant_argument_values rules.

* rfrac: Removed unused imports.

* enabled unnecessary_parenthesis.
This was referenced Jan 1, 2022
Merged
Merged
@aman-singh7 aman-singh7 mentioned this issue Jan 14, 2022
Closed
This was referenced Jan 15, 2022
Closed
Closed
Closed
@remote007
Copy link

@ItsAdityaKSingh is this still open to MR ?

@ItsAdityaKSingh
Copy link
Contributor

@remote007 I have made a PR for it which hasn't been reviewed yet.

@aman-singh7 aman-singh7 mentioned this issue Jun 5, 2022
Merged
@aman-singh7 aman-singh7 pinned this issue Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Hacktoberfest
Projects
None yet
Milestone
No milestone
7 participants
@manjotsidhu @remote007 @Aadeesh11 @ItsAdityaKSingh @Neha62-lit @aman-singh7 @devansh12b2