Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable linter rules #172

Merged
merged 2 commits into from
Nov 26, 2021
Merged

Enable linter rules #172

merged 2 commits into from
Nov 26, 2021

Conversation

aman-singh7
Copy link
Member

Fixes #149

Describe the changes you have made in this PR -
Enable following linter rules-

  • always_put_required_named_parameters_first

  • join_return_with_assignment

Screenshots of the changes (If any) -

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@coveralls
Copy link

coveralls commented Nov 26, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1506188114

  • 39 of 44 (88.64%) changed or added relevant lines in 16 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 73.559%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/utils/enum_values.dart 0 1 0.0%
lib/services/database_service.dart 0 2 0.0%
lib/services/ib_engine_service.dart 4 6 66.67%
Files with Coverage Reduction New Missed Lines %
lib/ui/views/ib/components/ib_pop_quiz_button.dart 1 0%
Totals Coverage Status
Change from base Build 1490536527: 0.01%
Covered Lines: 3853
Relevant Lines: 5238
💛 - Coveralls

manjotsidhu
manjotsidhu approved these changes Nov 26, 2021
View reviewed changes
Copy link
Member

@manjotsidhu manjotsidhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Good Work @aman-singh7

@manjotsidhu
Copy link
Member

Try to follow conventional commit specification 😎

@manjotsidhu manjotsidhu merged commit fdd62be into CircuitVerse:master Nov 26, 2021
@aman-singh7 aman-singh7 deleted the fix_linter branch March 3, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manjotsidhu manjotsidhu manjotsidhu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix and enable linter rules
3 participants
@aman-singh7 @coveralls @manjotsidhu