Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated dependencies and files with Flutter 2.10 #188

Merged
merged 24 commits into from
Mar 14, 2022
Merged

Updated dependencies and files with Flutter 2.10 #188

merged 24 commits into from
Mar 14, 2022

Conversation

ItsAdityaKSingh
Copy link
Contributor

@ItsAdityaKSingh ItsAdityaKSingh commented Jan 1, 2022 •
edited
Loading

Describe the changes you have made in this PR - Updated dependencies, sorted them, and added a updates for successful runs in Flutter version 2.10+

@ItsAdityaKSingh ItsAdityaKSingh changed the title updated Updated dependencies Jan 1, 2022
@coveralls
Copy link

coveralls commented Jan 1, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1981338234

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.718%
Totals Coverage Status
Change from base Build 1926492772: 0.0%
Covered Lines: 3910
Relevant Lines: 5529
💛 - Coveralls

manjotsidhu
manjotsidhu reviewed Jan 2, 2022
View reviewed changes
analysis_options.yaml Outdated Show resolved Hide resolved
@ItsAdityaKSingh
Copy link
Contributor Author

@manjotsidhu Could you review these updates?

@ItsAdityaKSingh ItsAdityaKSingh changed the title Updated dependencies Updated dependencies and files with Flutter 2.10 Feb 13, 2022
@ItsAdityaKSingh
Copy link
Contributor Author

@manjotsidhu, please review these changes.

@manjotsidhu
Copy link
Member

@aman-singh7 Can you review these changes, I am busy

@aman-singh7
Copy link
Member

@ItsAdityaKSingh Please rebase your branch changes with the master.

@aman-singh7
Copy link
Member

aman-singh7 commented Mar 13, 2022 •
edited
Loading

@ItsAdityaKSingh Can you also update the Podfile?

@ItsAdityaKSingh
Copy link
Contributor Author

@aman-singh7 There are no such updates for the Podfile while running the app with latest changes.

@aman-singh7
Copy link
Member

@ItsAdityaKSingh Have you tried to build it for ios?

@ItsAdityaKSingh
Copy link
Contributor Author

@aman-singh7 There was no Podfile updates, only these minor ones :)

@aman-singh7
Copy link
Member

aman-singh7 commented Mar 14, 2022 •
edited
Loading

@manjotsidhu I have tested the app on android and there are no such issues. I think we can go with it.

@manjotsidhu manjotsidhu merged commit 3a36b23 into CircuitVerse:master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manjotsidhu manjotsidhu manjotsidhu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ItsAdityaKSingh @coveralls @manjotsidhu @aman-singh7