Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lints): prefer const declarations #155

Merged
merged 1 commit into from
Oct 11, 2021
Merged

fix(lints): prefer const declarations #155

merged 1 commit into from
Oct 11, 2021

Conversation

manjotsidhu
Copy link
Member

Refer #149

Fix lint rules and clean analysis_options.yml -

  • Remove the rules which are already enabled since they are true by default.
  • Fixed prefer_const_declarations rule

Signed-off-by: Manjot Sidhu <manjot.techie@gmail.com>
@manjotsidhu manjotsidhu requested a review from Nitish145 October 10, 2021 05:54
@coveralls
Copy link

coveralls commented Oct 10, 2021

Pull Request Test Coverage Report for Build 1325154715

  • 20 of 31 (64.52%) changed or added relevant lines in 16 files are covered.
  • 9 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.5%) to 73.654%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ui/views/authentication/forgot_password_view.dart 0 1 0.0%
lib/ui/views/authentication/login_view.dart 0 1 0.0%
lib/ui/views/groups/add_assignment_view.dart 2 3 66.67%
lib/ui/views/groups/update_assignment_view.dart 1 2 50.0%
lib/ui/views/ib/ib_landing_view.dart 0 1 0.0%
lib/ui/views/projects/edit_project_view.dart 0 1 0.0%
lib/ui/views/projects/project_details_view.dart 1 3 33.33%
lib/utils/router.dart 3 6 50.0%
Files with Coverage Reduction New Missed Lines %
lib/ui/views/about/about_privacy_policy_view.dart 1 96.12%
lib/ui/views/contributors/components/contributors_donate_card.dart 1 85.0%
lib/ui/views/contributors/components/contributors_support_card.dart 1 94.44%
lib/ui/views/home/components/feature_card.dart 1 93.33%
lib/ui/views/ib/ib_page_view.dart 1 59.57%
lib/ui/views/projects/featured_projects_view.dart 1 86.67%
lib/ui/views/teachers/components/teachers_card.dart 1 94.74%
lib/ui/views/projects/project_details_view.dart 2 36.3%
Totals Coverage Status
Change from base Build 1320117713: -0.5%
Covered Lines: 3844
Relevant Lines: 5219

💛 - Coveralls

@manjotsidhu
Copy link
Member Author

@Neha62-lit you can review this

@Neha62-lit
Copy link
Contributor

@Neha62-lit you can review this

Okay👍

@manjotsidhu manjotsidhu requested a review from tachyons October 10, 2021 13:34
@manjotsidhu manjotsidhu merged commit 11dbccf into master Oct 11, 2021
@manjotsidhu manjotsidhu deleted the fix-lints-2 branch October 11, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants