Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added flutter-lints package #148

Merged
merged 3 commits into from
Oct 5, 2021
Merged

feat: added flutter-lints package #148

merged 3 commits into from
Oct 5, 2021

Conversation

Neha62-lit
Copy link
Contributor

@Neha62-lit Neha62-lit commented Oct 5, 2021

Fixes #136

Describe the changes you have made in this PR -

  1. Added all proper linter rules.
  2. Migrated flutter-lints package.

Screenshots of the changes (If any) -

This screenshot shows that "No issues found" i.e there is no warnings/errors in the code.

Screenshot (160)

@Neha62-lit
Copy link
Contributor Author

Hey @manjotsidhu, Please review and merge PR.

Copy link
Member

@manjotsidhu manjotsidhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍

@manjotsidhu
Copy link
Member

manjotsidhu commented Oct 5, 2021

@Neha62-lit could you make a new Issue with the checklist of all the issues that are disabled ? It would be easy for us to track later. I will merge this PR once the CI checks are successful.

@Neha62-lit
Copy link
Contributor Author

@Neha62-lit could you make a new Issue with the checklist of all the issues that are disabled ? It would be easy for us to track later. I will merge this PR once the CI checks are successful.

Can you explain me, What I have to do here?

@manjotsidhu manjotsidhu changed the title Added flutter-lints package feat: added flutter-lints package Oct 5, 2021
@coveralls
Copy link

coveralls commented Oct 5, 2021

Pull Request Test Coverage Report for Build 1306847144

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.718%

Totals Coverage Status
Change from base Build 1304734142: 0.0%
Covered Lines: 3924
Relevant Lines: 5323

💛 - Coveralls

@manjotsidhu
Copy link
Member

@Neha62-lit could you make a new Issue with the checklist of all the issues that are disabled ? It would be easy for us to track later. I will merge this PR once the CI checks are successful.

Can you explain me, What I have to do here?

You have to create a new issue for fixing flutter_lints rules and in that issue we can manage the checklist of the rules which are to fixed.

@manjotsidhu manjotsidhu merged commit a1690ac into CircuitVerse:master Oct 5, 2021
@Neha62-lit
Copy link
Contributor Author

@Neha62-lit could you make a new Issue with the checklist of all the issues that are disabled ? It would be easy for us to track later. I will merge this PR once the CI checks are successful.

Can you explain me, What I have to do here?

You have to create a new issue for fixing flutter_lints rules and in that issue we can manage the checklist of the rules which are to fixed.

Okay, will do that.

@Neha62-lit Neha62-lit mentioned this pull request Oct 6, 2021
27 tasks
@Neha62-lit Neha62-lit deleted the flutterLint branch October 7, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flutter 2.5: Migrate to recommended flutter_lints package
3 participants