fix(lints): linter rules #149 (#179)

* rfrac: enabled unnecessary_parenthesis and avoid_redundant_argument_values rules. * rfrac: Removed unused imports. * enabled unnecessary_parenthesis.
CircuitVerse · Dec 24, 2021 · ba90d7a · ba90d7a
1 parent 8b50d69
commit ba90d7a
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 7 deletions.
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -8,8 +8,6 @@ linter:
     # Util classes
     avoid_classes_with_only_static_members: false
 
-    avoid_redundant_argument_values: false
-
     non_constant_identifier_names: false
 
     constant_identifier_names: false
diff --git a/lib/ui/views/groups/add_assignment_view.dart b/lib/ui/views/groups/add_assignment_view.dart
@@ -146,7 +146,7 @@ class _AddAssignmentViewState extends State<AddAssignmentView> {
           value: _restrictions.contains(name),
           onChanged: (value) {
             if (value) {
-              _restrictions.add((name));
+              _restrictions.add(name);
             } else {
               _restrictions.remove(name);
             }

diff --git a/lib/ui/views/groups/update_assignment_view.dart b/lib/ui/views/groups/update_assignment_view.dart
@@ -126,7 +126,7 @@ class _UpdateAssignmentViewState extends State<UpdateAssignmentView> {
             value: _restrictions.contains(name),
             onChanged: (value) {
               if (value) {
-                _restrictions.add((name));
+                _restrictions.add(name);
               } else {
                 _restrictions.remove(name);
               }

diff --git a/test/service_tests/assignments_api_test.dart b/test/service_tests/assignments_api_test.dart
@@ -189,7 +189,7 @@ void main() {
             (_) => Future.value(Response('{"message": "reopened"}', 200)));
         var _assignmentsApi = HttpAssignmentsApi();
 
-        expect((await _assignmentsApi.reopenAssignment('1')), 'reopened');
+        expect(await _assignmentsApi.reopenAssignment('1'), 'reopened');
       });
 
       test('When called & http client throws Exceptions', () async {
@@ -219,7 +219,7 @@ void main() {
             Future.value(Response('{"message": "project created"}', 200)));
         var _assignmentsApi = HttpAssignmentsApi();
 
-        expect((await _assignmentsApi.startAssignment('1')), 'project created');
+        expect(await _assignmentsApi.startAssignment('1'), 'project created');
       });
 
       test('When called & http client throws Exceptions', () async {

diff --git a/test/service_tests/users_api_test.dart b/test/service_tests/users_api_test.dart
@@ -213,7 +213,7 @@ void main() {
 
         ApiUtils.client = MockClient((_) =>
             Future.value(Response('{"message": "instructions sent"}', 200)));
-        expect((await _usersApi.sendResetPasswordInstructions('test@test.com')),
+        expect(await _usersApi.sendResetPasswordInstructions('test@test.com'),
             true);
       });