Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cd): enable deployments via GitHub releases #128

Merged
merged 4 commits into from
Aug 16, 2021

Conversation

Nitish145
Copy link
Member

Describe the changes you have made in this PR -

  • Uses GitHub releases & associated tags to ship the app to play store.
  • gh-actions accepts 'vx.y.z-beta' for beta builds and 'vx.y.z' for prod builds.

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@coveralls
Copy link

coveralls commented Aug 16, 2021

Pull Request Test Coverage Report for Build 1135272599

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 15 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 74.053%

Files with Coverage Reduction New Missed Lines %
lib/ui/views/cv_landing_view.dart 15 59.8%
Totals Coverage Status
Change from base Build 1126029342: 0.0%
Covered Lines: 3910
Relevant Lines: 5280

💛 - Coveralls

@manjotsidhu
Copy link
Member

We can delete deploy branch after merging this since it will not be required. Also, a corner case would be where I can make release based off branch another than master. I feel we should only allow from master branch.

@Nitish145 Nitish145 requested a review from manjotsidhu August 16, 2021 10:56
.github/workflows/cd.yml Outdated Show resolved Hide resolved
@tachyons
Copy link
Member

@tachyons
Copy link
Member

@tachyons
Copy link
Member

https://www.conventionalcommits.org/en/about/ There are some tools listed here, we should explore them as well to improve the workflow by making use of conventional commits structure we decided to follow

@Nitish145
Copy link
Member Author

https://github.com/xotahal/fastlane-plugin-semantic_release

This looks great! @manjotsidhu would you want to take this ahead? Maybe in this PR or another one.

@manjotsidhu
Copy link
Member

https://github.com/xotahal/fastlane-plugin-semantic_release

This looks great! @manjotsidhu would you want to take this ahead? Maybe in this PR or another one.

Sure, I think we can handle that in a new PR.

@manjotsidhu manjotsidhu changed the title Setup Deployment feat(cd): enable deployments via GitHub releases Aug 16, 2021
@manjotsidhu manjotsidhu merged commit e33e140 into master Aug 16, 2021
@manjotsidhu manjotsidhu deleted the setup-deployment branch August 16, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants