Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: Hidden FAB's in Interactive Book are active when hidden. #173 #174

Merged
merged 1 commit into from
Dec 5, 2021

Conversation

Aadeesh11
Copy link
Contributor

Fixes #173

Describe the changes you have made in this PR -
Hidden FAB's are now inactive, i.e do not do anything when tapped.

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Copy link
Member

@manjotsidhu manjotsidhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Your changes are great. But let's look at a bigger picture. First we need to understand that those buttons are "invisible" such that even if they are not visible, they take the space since it's opacity is only set. Is there a better way to simply remove the fab button instead of just hiding it ? If that's possible then that would already fix the onclick behaviour since it will be gone. If it's not possible then we can consider these changes as the best solution to the issue.

@Aadeesh11
Copy link
Contributor Author

Aadeesh11 commented Dec 4, 2021

@manjotsidhu thanks for your insights, will try to remove the FAB button.

@manjotsidhu
Copy link
Member

@manjotsidhu thanks for your insights, will try to remove the FAB button.

Just try, if nothing works out then we can use this change.

@coveralls
Copy link

coveralls commented Dec 4, 2021

Pull Request Test Coverage Report for Build 1538954400

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 73.502%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ui/views/ib/ib_page_view.dart 0 6 0.0%
Totals Coverage Status
Change from base Build 1507540316: -0.06%
Covered Lines: 3853
Relevant Lines: 5242

💛 - Coveralls

@Aadeesh11
Copy link
Contributor Author

@manjotsidhu I tried removing the FAB buttons, but in this case we don't have the nice fade in/out effect on the buttons.
In this case buttons appear/disappear suddenly instead of fading.

@manjotsidhu manjotsidhu merged commit 9f70495 into CircuitVerse:master Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Hidden FAB's in Interactive Book are active when hidden.
3 participants