Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: search on the interactive book page #229

Merged
merged 6 commits into from
Jul 8, 2022
Merged

feat: search on the interactive book page #229

merged 6 commits into from
Jul 8, 2022

Conversation

aman-singh7
Copy link
Member

Signed-off-by: Aman aman2@me.iitr.ac.in

Fixes #224

Describe the changes you have made in this PR -

Screenshots of the changes (If any) -

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Signed-off-by: Aman <aman2@me.iitr.ac.in>
…query in its content

Signed-off-by: Aman <aman2@me.iitr.ac.in>
Signed-off-by: Aman <aman2@me.iitr.ac.in>
Signed-off-by: Aman <aman2@me.iitr.ac.in>
@coveralls
Copy link

coveralls commented Jul 5, 2022

Pull Request Test Coverage Report for Build 2637365299

  • 23 of 156 (14.74%) changed or added relevant lines in 6 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.4%) to 67.782%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ui/views/ib/builders/ib_headings_builder.dart 1 2 50.0%
lib/ui/views/ib/ib_page_view.dart 6 7 85.71%
lib/ui/views/ib/syntaxes/ib_highlight_syntax.dart 0 4 0.0%
lib/ui/views/ib/builders/ib_highlight_builder.dart 1 11 9.09%
lib/ui/views/ib/ib_landing_view.dart 13 56 23.21%
lib/viewmodels/ib/ib_landing_viewmodel.dart 2 76 2.63%
Files with Coverage Reduction New Missed Lines %
lib/viewmodels/ib/ib_landing_viewmodel.dart 1 7.96%
lib/ui/views/ib/ib_landing_view.dart 2 53.04%
Totals Coverage Status
Change from base Build 2601505179: -1.4%
Covered Lines: 3991
Relevant Lines: 5888

💛 - Coveralls

Signed-off-by: Aman <aman2@me.iitr.ac.in>
Signed-off-by: Aman <aman2@me.iitr.ac.in>
@manjotsidhu manjotsidhu merged commit 507ef51 into master Jul 8, 2022
@manjotsidhu manjotsidhu deleted the ib_search branch July 8, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search Feature in Interactive Book
3 participants