Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement multiple mentor support in groups #232

Merged
merged 3 commits into from
Jul 14, 2022

Conversation

aman-singh7
Copy link
Member

Signed-off-by: Aman aman2@me.iitr.ac.in

Fixes #228

Describe the changes you have made in this PR -

Screenshots of the changes (If any) -

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Signed-off-by: Aman <aman2@me.iitr.ac.in>
Signed-off-by: Aman <aman2@me.iitr.ac.in>
@aman-singh7 aman-singh7 requested a review from manjotsidhu July 9, 2022 14:04
@manjotsidhu
Copy link
Member

@aman-singh7 Can you check if there a action that can automatically update podfile for us ?

@manjotsidhu
Copy link
Member

Nice hack, in future if the action could also make a PR for podfile updates that would be better

Signed-off-by: Aman <aman2@me.iitr.ac.in>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2649532758

  • 86 of 153 (56.21%) changed or added relevant lines in 12 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 67.236%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ui/views/groups/my_groups_view.dart 5 6 83.33%
lib/services/API/group_members_api.dart 0 13 0.0%
lib/viewmodels/groups/group_details_viewmodel.dart 14 33 42.42%
lib/ui/views/groups/group_details_view.dart 35 69 50.72%
Totals Coverage Status
Change from base Build 2637822211: -0.5%
Covered Lines: 4012
Relevant Lines: 5967

💛 - Coveralls

@manjotsidhu manjotsidhu merged commit ea9a5b3 into master Jul 14, 2022
@coveralls
Copy link

coveralls commented Dec 22, 2024

Pull Request Test Coverage Report for Build 2649532758

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 86 of 153 (56.21%) changed or added relevant lines in 12 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 67.236%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ui/views/groups/my_groups_view.dart 5 6 83.33%
lib/services/API/group_members_api.dart 0 13 0.0%
lib/viewmodels/groups/group_details_viewmodel.dart 14 33 42.42%
lib/ui/views/groups/group_details_view.dart 35 69 50.72%
Totals Coverage Status
Change from base Build 2637822211: -0.5%
Covered Lines: 4012
Relevant Lines: 5967

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Multiple Mentor Support
3 participants