Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gsoc'24): markdown syntax extension for user tagging, circuit and video embedding #27

Open
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

Waishnav
Copy link

@Waishnav Waishnav commented Jul 22, 2024

Fixes #15

Note: Please ignore the js build files changes. since they are needed to push for the engine to work in production

This PR's covers following functionality

  • added the markdown syntax extension at both client side and server side for
  1. Embedding circuits
  2. Embedding video
  3. Tagging user
  • Feature flags are used for purpose of enabling and disabling this markdown extension.
SimpleDiscussion.setup do |config|
  config.markdown_circuit_embed = false # Default: true
  config.markdown_user_tagging = false # Default: true
  config.markdown_video_embed = false # Default: true
end

Screenshots:

  1. Embed circuit modal when user clicks on embed-circuit button from toolbar
    image

  2. Embed video when user clicks on embed-video button from toolbar
    image

  3. User tagging dropdown
    image

  4. Server rendered forum post
    image

@Waishnav Waishnav marked this pull request as ready for review July 22, 2024 18:52
@Waishnav Waishnav changed the title Markdown syntax extensions feat(gsoc'24): markdown syntax extension for user tagging, circuit and video embedding Jul 22, 2024
Waishnav added 26 commits July 25, 2024 15:46
…r` gem

- these filters are applied on forum_thread's title, forum_posts's body
- error messages are now improves with proper altert message styling
  using bootstrap's alter class
…r` gem

- these filters are applied on forum_thread's title, forum_posts's body
- error messages are now improves with proper altert message styling
  using bootstrap's alter class
@Waishnav Waishnav force-pushed the markdown-syntax-extensions branch from af7abf8 to 6aa414d Compare July 28, 2024 18:18
@Waishnav Waishnav force-pushed the markdown-syntax-extensions branch from 6aa414d to d9c8170 Compare July 28, 2024 18:19
@Waishnav Waishnav force-pushed the markdown-syntax-extensions branch from e4b3a30 to ff24eb5 Compare July 28, 2024 18:24
@Waishnav Waishnav force-pushed the markdown-syntax-extensions branch from 35bc457 to 324e97e Compare August 14, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown Editor support
1 participant