Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixing responsiveness and overlfow issues #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DhairyaMajmudar
Copy link

@DhairyaMajmudar DhairyaMajmudar commented Jan 11, 2024

Fix :-

  1. 🐞 Bug: Issues with the sidebar in forum section.  CircuitVerse#4554
  2. 🐞 Bug: Overflow in medium and small screens.  CircuitVerse#4575
  • Fixing Responsiveness issues in the medium-sized screen ( Tablets / large mobiles )

Before ScreenShot
image

After ScreenShot
image

@DhairyaMajmudar
Copy link
Author

@tanmoysrt pls. review.

Copy link
Member

@tanmoysrt tanmoysrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of squeezing the sidebare you can try to squeeze other contents.

@DhairyaMajmudar
Copy link
Author

Instead of squeezing the sidebare you can try to squeeze other contents.

By internal content do you mean internal divs?

@tanmoysrt
Copy link
Member

Instead of squeezing the sidebare you can try to squeeze other contents.

By internal content do you mean internal divs?> Instead of squeezing the sidebare you can try to squeeze other contents.

I mean for tab like size , in sidebar try to keep the buttons same as desktop, the text in single line rather than breaking in two line

@DhairyaMajmudar DhairyaMajmudar changed the title Fixing responsiveness in medium screens. Fixing responsiveness and overlfow issues Jan 12, 2024
@DhairyaMajmudar
Copy link
Author

@tanmoysrt I have updated my pr pls. take a look

@DhairyaMajmudar DhairyaMajmudar changed the title Fixing responsiveness and overlfow issues Fix: Fixing responsiveness and overlfow issues Feb 15, 2024
@DhairyaMajmudar
Copy link
Author

DhairyaMajmudar commented Feb 24, 2024

@tanmoysrt I have made the suggested changes, if it looks good can you pls. merge the pr?

cc: @vedant-jain03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants