Coverity 416446: Fix possible NULL dereference

Missing a NULL-check before calling `cli_unlink()` which has no NULL check of its own before calling `unlink`.
Cisco-Talos · Aug 8, 2023 · 4c34301 · 4c34301
1 parent 5893708
commit 4c34301
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/libclamav/udf.c b/libclamav/udf.c
@@ -89,11 +89,13 @@ static cl_error_t writeWholeFile(cli_ctx *ctx, const char *const fileName, const
         fd = -1;
     }
     if (!ctx->engine->keeptmp) {
-        if (cli_unlink(tmpf)) {
-            /* If status is already set to virus or something, that should take priority of the
-             * error unlinking the file. */
-            if (CL_CLEAN == status) {
-                status = CL_EUNLINK;
+        if (NULL != tmpf) {
+            if (cli_unlink(tmpf)) {
+                /* If status is already set to virus or something, that should take priority of the
+                 * error unlinking the file. */
+                if (CL_CLEAN == status) {
+                    status = CL_EUNLINK;
+                }
             }
         }
     }