Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clam 2436 no clap no atty 1.1.3 #1034

Merged

Conversation

micahsnyder
Copy link
Contributor

Backport of #1021 for 1.1.3

atty is unmaintained but is still used by clap.
Disabling the default features for cbindgen removes the clap
dependency and thus removes atty.

Resolves: https://github.com/Cisco-Talos/clamav/security/dependabot/2
The build is running a different link.exe than the MSVC linker,
possibly the one provided by bash.

Fix by deleting /usr/bin/link.exe

See: https://yncat.github.io/2022/02/18/github-actions%E3%81%A7-msvc-%E3%81%AE-link-%E3%81%8C%E4%BD%BF%E3%81%88%E3%81%AA%E3%81%8F%E3%81%AA%E3%82%8B%E8%A9%B1.html
@micahsnyder micahsnyder force-pushed the CLAM-2436-no-clap-no-atty-1.1.3 branch from 7e2955b to aedca40 Compare October 20, 2023 23:17
@micahsnyder micahsnyder merged commit 9601bba into Cisco-Talos:dev/1.1.3 Oct 23, 2023
23 of 24 checks passed
@micahsnyder micahsnyder deleted the CLAM-2436-no-clap-no-atty-1.1.3 branch October 23, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant