CMake: fix libclamav-only mode build when tests are enable #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragusaa
approved these changes
Oct 13, 2022
CMake's configuration step fails if you use ENABLE_LIBCLAMAV_ONLY=ON and ENABLE_TESTS=ON. This is because we try to add the libcurl module path to the test environment, for the sake of linking with the Rust unit test program, as we do with the other dependencies. However, libcurl is not required or even found in libclamav-only mode. So that fails.
micahsnyder
force-pushed
the
CLAM-2126-libclamav-only-with-tests
branch
from
faac3f2
to
8546a11
Compare
|
Rebased and force-pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake's configuration step fails if you use ENABLE_LIBCLAMAV_ONLY=ON and ENABLE_TESTS=ON. This is because we try to add the libcurl module path to the test environment, for the sake of linking with the Rust unit test program, as we do with the other dependencies. However, libcurl is not required or even found in libclamav-only mode. So that fails.