[minor_change] Optimization through an additional api call at list-identity schema endpoint to avoid retrieval of all schemas in order to get the id of a schema (DCNE-208) #302
+49
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinross
force-pushed
the
optimize_schema_datasource_for_large_schemas
branch
from
8770ca1
to
a4568db
Compare
…entity schema endpoint to avoid retrieval of all schemas in order to get the id of a schema
akinross
force-pushed
the
optimize_schema_datasource_for_large_schemas
branch
from
a4568db
to
ec71511
Compare
akinross
requested review from
lhercot,
shrsr,
anvitha-jain,
sajagana,
samiib and
gmicol
github-actions
bot
changed the title
anvitha-jain
requested changes
Oct 16, 2024
| con, err := msoClient.GetViaURL("/api/v1/schemas/list-identity") | ||
|
|
||
| if err != nil { | ||
| return "", nil |
There was a problem hiding this comment.
can we cahnge the return "" -> "Endpoint not found" ?
then we can run the other part of code.
then from line 241 if return "" the we will not run the old code.
There was a problem hiding this comment.
I am not sure I follow exactly what you mean, do you want to return a string with a specific value?
Why would "" not run the old code?
The cases that I now see from the code are the following:
- errors for whatever reason -> return "", nil -> executes the else clause in line 91 of the datasource, which means fallback to the existing code and schema endpoint
- find the name in from response -> return schemaId, nil -> executes the else if condition in line 86 of the datasource where schemaId is a non empty string value and does a specific query for this schemaId
- does not find name in response -> return "", err -> return the error in line 85 of the datasource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.