SIMPLE-5729 uploading image files now keeps the extension, removed old deprecated parameter from upload_image_file #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-valent
force-pushed
the
SIMPLE-5729-virl2-client-s-upload_image_file-strips-the-.qcow2-extension
branch
5 times, most recently
from
3ba1795
to
6a43140
Compare
PatrikMosko
reviewed
Aug 18, 2023
PatrikMosko
reviewed
Aug 18, 2023
PatrikMosko
reviewed
Aug 18, 2023
|
Tests pass, every seems (finally) ready to merge, unless there are further comments. |
…d deprecated parameter from upload_image_file SIMPLE-5729 improved image upload unit test, now checks the API call
tmikuska
force-pushed
the
SIMPLE-5729-virl2-client-s-upload_image_file-strips-the-.qcow2-extension
branch
from
27535fb
to
597929f
Compare
tmikuska
deleted the
SIMPLE-5729-virl2-client-s-upload_image_file-strips-the-.qcow2-extension
branch
tmikuska
pushed a commit
that referenced
this pull request
Aug 18, 2023
…d deprecated parameter from upload_image_file (#50) SIMPLE-5729 improved image upload unit test, now checks the API call
tmikuska
added a commit
that referenced
this pull request
Sep 4, 2023
* Bumped version to 2.6.1 Updated vulnerable packages * SIMPLE-5729 uploading image files now keeps the extension, removed old deprecated parameter from upload_image_file (#50) SIMPLE-5729 improved image upload unit test, now checks the API call * Updated vulnerable gitpython and aiohttp, regenerated test requirements --------- Co-authored-by: Daniel Valent <dvalent@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I thought there were some inefficiencies in upload_image_file... And when I fixed them, all related test died. So never mind that. Don't touch the Path related things, something about the way they are imported makes them fragile.
E: Found what the problem was - we are testing Windows paths on Linux, so we have to use PureWindowsPath instead of WindowsPath in tests, which means no interaction with system, which means no Path.exists(). Means that my changes worked fine, but broke tests.