Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untangle sync of global config vs. options settings #1279

Closed
originalfoo opened this issue Jan 8, 2022 · 0 comments · Fixed by #1432
Closed

Untangle sync of global config vs. options settings #1279

originalfoo opened this issue Jan 8, 2022 · 0 comments · Fixed by #1432
Assignees
@originalfoo
Labels
Settings Road config, mod options, config xml technical Tasks that need to be performed in order to improve quality and maintainability
Milestone
11.6.5.1

Comments

@originalfoo
Copy link
Member

Currently the way settings that exist both in GlobalConfig and Options are synchronised is a bit of a mess.

Housekeeping task to reduce duplication pending #1267

Ultimately persistence system will be updated so that there's only ever one version of an option, as described in #562

Once detangled should make it a bit easier to transition some settings to CheckboxOption.
@originalfoo originalfoo added technical Tasks that need to be performed in order to improve quality and maintainability Settings Road config, mod options, config xml labels Jan 8, 2022
@originalfoo originalfoo self-assigned this Jan 24, 2022
@originalfoo originalfoo added this to the 11.7.0 milestone Jan 24, 2022
This was referenced Feb 5, 2022
Merged
Open
Merged
@originalfoo originalfoo modified the milestones: 11.7.0, 11.6.5.1 Feb 15, 2022
@originalfoo originalfoo mentioned this issue Feb 23, 2022
Merged
9 tasks
@originalfoo originalfoo mentioned this issue Feb 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@originalfoo originalfoo

Labels
Settings Road config, mod options, config xml technical Tasks that need to be performed in order to improve quality and maintainability
Projects
None yet
Milestone
11.6.5.1
Development

Successfully merging a pull request may close this issue.

Refactor remainder of General tab CitiesSkylinesMods/TMPE
1 participant
@originalfoo