Refactor remainder of General tab
#1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
originalfoo
added
UI
originalfoo
added
Usability
4 tasks
originalfoo
added
the
DO NOT MERGE YET
1 task
Mod checker stuff is global, not savegame.
originalfoo
changed the title
General tabGeneral tab
|
ready for review |
originalfoo
removed
DO NOT MERGE YET
- Move `MayPublishSegmentChanges()` to `TMPELifecycle` class - Mark `OptionsManager` as obsolete and redirect to `TMPELifecycle`
|
@krzychu124 Any feedback on this PR? It's blocking the maintenance tab PR. |
krzychu124
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of ongoing work on #1356 phase 2 - #1356 (comment)
Changes
InterfacegroupOverlay transparencytoOverlay opacity#1268SimulationgroupCompatibilitygroupApply AI changes right awayoptionMayPublishSegmentChanges()toTMPELifecycleclass (it has nothing to do with mod options)Notes
OverlayTransparencytoOverlayOpacitycurrently just resetsOverlayOpacityto default value. I couldn't find any obvious place to manage global config version transitions.MINIMUM_OPACITY(10%) constant which should prevent users setting 0% opacity and then complaining that overlays aren't appearing :)MAXIMUM_OPACITY(100%) rather than doing bitshifting, etc. LMK what you think - should I change it back how it was before?Issues
Fixes: #1409
Fixes: #1268
Fixes: #1279
Updates: #1262
Updates: #62
Supercedes: #1267