Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TM:PE settings not copy pasted in-game #1303

Merged
merged 3 commits into from
Jan 23, 2022
Merged

Conversation

krzychu124
Copy link
Member

@krzychu124 krzychu124 commented Jan 22, 2022

Fix typo resulting in wrong lane id while applying settings on pasted segments with MoveIt

Partial fix for #1300, other bugs are simulation timing related -> require queuing and applying change records in the next SimulationStep instead of current (node flags are not fully initialized right after creation)

Full implementation of fix for transferring TMPE settings with use of MoveIt integration plugin!
Closes #1300

Build zip

@krzychu124 krzychu124 added BUG Defect detected confirmed Represents confirmed issue or bug SPEED LIMITS Feature: Speed limits Asset Editor Issue related to TM:PE support in content editors labels Jan 22, 2022
@krzychu124 krzychu124 added this to the 11.6.4 milestone Jan 22, 2022
@krzychu124 krzychu124 self-assigned this Jan 22, 2022
@krzychu124 krzychu124 changed the title Speed limits not copy pasted in-game TM:PE settings not copy pasted in-game Jan 22, 2022
…work gets copy-pasted with help of integration plugin
@krzychu124
Copy link
Member Author

I've added a fix to resolve all issues with integration plugin

@krzychu124 krzychu124 requested a review from kvakvs January 22, 2022 20:54
Copy link
Contributor

@chameleon-tbn chameleon-tbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@originalfoo
Copy link
Member

Is there possibility of similar issues arising when user plops assets that contain TM:PE settings (defined in asset editor)?

@krzychu124
Copy link
Member Author

Is there possibility of similar issues arising when user plops assets that contain TM:PE settings (defined in asset editor)?

I've created one simple intersection with all possible settings (using this build) and everything works in-game. Ovelay caching is broken so when you use it to check if everything was restored you need to switch tools to force refresh. I plan to fix overlays in 11.7.x, not a big deal for now.

Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in-game for a bit and seems to work fine.

@krzychu124
Copy link
Member Author

Is there possibility of similar issues arising when user plops assets that contain TM:PE settings (defined in asset editor)?

Correction -> issue still exist when IMT or NCR is enabled. I found the problem and solution.
Merging...

@krzychu124 krzychu124 merged commit f8b90cf into master Jan 23, 2022
@krzychu124 krzychu124 deleted the speedlimit-copy-paste branch January 23, 2022 05:17
@originalfoo originalfoo mentioned this pull request Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Asset Editor Issue related to TM:PE support in content editors BUG Defect detected confirmed Represents confirmed issue or bug SPEED LIMITS Feature: Speed limits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MoveItIntegration plugin - settings are not copy-pasted on segment clone with MoveIt
4 participants