Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/parked vehicles extensions #1407

Merged
merged 5 commits into from
Feb 15, 2022

Conversation

DaEgi01
Copy link
Contributor

@DaEgi01 DaEgi01 commented Feb 15, 2022

Added ToParkedVehicle extension methods for convenience.
Adjusted existing code to use the new methods instead.

@DaEgi01 DaEgi01 added the code cleanup Refactor code, remove old code, improve maintainability label Feb 15, 2022
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built from source as DEBUG, tested in game very briefly - vehicles were parking fine, moving a building caused parking reshuffle as expected, etc.

LGTM 👍

@originalfoo originalfoo added this to the 11.6.5 milestone Feb 15, 2022
@DaEgi01 DaEgi01 merged commit 7f6c8ea into master Feb 15, 2022
@DaEgi01 DaEgi01 deleted the refactoring/ParkedVehiclesExtensions branch February 15, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Refactor code, remove old code, improve maintainability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants