Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools GUI windows - disable click through UI background #1443

Merged
merged 7 commits into from
Mar 4, 2022
Merged

Tools GUI windows - disable click through UI background #1443

merged 7 commits into from
Mar 4, 2022

Conversation

krzychu124
Copy link
Member

Closes #934
Closes #749

Additional changes:
Hotfix for What's New panel version check - throws NullReferenceException if working with default values in GlobalConfig (can compare Version with null but not the other way around)

@krzychu124 krzychu124 added BUG Defect detected Usability Make mod easier to use confirmed Represents confirmed issue or bug UI User interface updates labels Feb 28, 2022
@krzychu124 krzychu124 self-assigned this Feb 28, 2022
@originalfoo
Copy link
Member

Code looks good, will test in game tonight.

@originalfoo originalfoo added this to the 11.6.5.1 milestone Mar 1, 2022
originalfoo
originalfoo approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised as far as I can tell. 👍

Wasn't sure what the secondary window was, but assuming it works on same principle it should work as expected.

@originalfoo originalfoo mentioned this pull request Mar 1, 2022
Merged
chameleon-tbn
chameleon-tbn approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@chameleon-tbn chameleon-tbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@krzychu124 krzychu124 merged commit 83a95d3 into master Mar 4, 2022
@krzychu124 krzychu124 deleted the bugfix/934-gui-window-disable-cursor-clicks branch March 4, 2022 00:58
@originalfoo originalfoo mentioned this pull request Mar 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@originalfoo originalfoo originalfoo approved these changes

@chameleon-tbn chameleon-tbn chameleon-tbn approved these changes

@kvakvs kvakvs Awaiting requested review from kvakvs

@kianzarrin kianzarrin Awaiting requested review from kianzarrin

Assignees

@krzychu124 krzychu124

Labels
BUG Defect detected confirmed Represents confirmed issue or bug UI User interface updates Usability Make mod easier to use
Projects
None yet
Milestone
11.6.5.1
Development

Successfully merging this pull request may close these issues.

Moving main panel in the background Panel backgrounds aren't absorbing mouse interactions
3 participants
@krzychu124 @originalfoo @chameleon-tbn