Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcuts.ShowErrorDialog -> Prompt.Error #1445

Merged
merged 5 commits into from
Mar 2, 2022
Merged

Shortcuts.ShowErrorDialog -> Prompt.Error #1445

merged 5 commits into from
Mar 2, 2022

Conversation

originalfoo
Copy link
Member

@originalfoo originalfoo commented Mar 1, 2022 •
edited
Loading

Compiled mod for testing: TMPE.zip

  • Replaced 4 calls to Shortcuts.ShowErrorDialog() with calls to Prompt.Error().
    • Does same thing but with some extra safeguards if used in-game
  • Removed Shortcuts.ShowErrorDialog() method as no longer used.
  • Update Prompt methods so they queue the dialog action in editor as well

@originalfoo
Shortcuts.ShowErrorDialog -> Prompt.Error
2d1046a 
Replaced 4 calls to `Shortcuts.ShowErrorDialog()` with calls to
`Prompt.Error()`.

Removed `Shortcuts.ShowErrorDialog()` method as no longer used.
@originalfoo originalfoo added the code cleanup Refactor code, remove old code, improve maintainability label Mar 1, 2022
@originalfoo originalfoo added this to the 11.6.5.1 milestone Mar 1, 2022
@originalfoo originalfoo self-assigned this Mar 1, 2022
@kianzarrin
Copy link
Collaborator

Sorry that was my bad. didn't see the prompt thing.

@originalfoo originalfoo merged commit 728baa1 into master Mar 2, 2022
@originalfoo originalfoo deleted the remove-ShowErrorDialog-shortcut branch March 2, 2022 18:12
This was referenced Mar 3, 2022
Merged
Closed
@originalfoo originalfoo mentioned this pull request May 9, 2022
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kianzarrin kianzarrin kianzarrin approved these changes

@krzychu124 krzychu124 krzychu124 approved these changes

@kvakvs kvakvs Awaiting requested review from kvakvs

Assignees

@originalfoo originalfoo

Labels
code cleanup Refactor code, remove old code, improve maintainability
Projects
None yet
Milestone
11.6.5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@originalfoo @kianzarrin @krzychu124