Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong texture atlas in scenario editor #1451

Merged
merged 5 commits into from
Mar 4, 2022
Merged

Fix wrong texture atlas in scenario editor #1451

merged 5 commits into from
Mar 4, 2022

Conversation

krzychu124
Copy link
Member

@krzychu124 krzychu124 commented Mar 3, 2022 •
edited
Loading

  • fixed wrong texture atlas used in scenario editor (thanks @kianzarrin for half of the work done via git patch file) 🙂
  • implemented UITextureAtlas release function, attached to MainMenuWindow.OnDestroy()
  • fixed memory leak on exit from Lane Arrows tool. (window improperly destroyed)

Closes #1449
Closes #1450

@krzychu124 krzychu124 added BUG Defect detected confirmed Represents confirmed issue or bug UI User interface updates Toolbar The main TMPE toolbar Asset Editor Issue related to TM:PE support in content editors labels Mar 3, 2022
@krzychu124 krzychu124 self-assigned this Mar 3, 2022
@originalfoo originalfoo added this to the 11.6.5.1 milestone Mar 3, 2022
originalfoo
originalfoo approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built from source, tested in scenario editor - LGTM 👍

@krzychu124
Copy link
Member Author

I've added fix for Lane Arrow window memory leak on close.

@krzychu124 krzychu124 merged commit f358ebb into master Mar 4, 2022
@krzychu124 krzychu124 deleted the bugfix/wrong-texture-atlas-in-scenario-editor branch March 4, 2022 04:16
@krzychu124 krzychu124 mentioned this pull request Mar 4, 2022
Merged
@originalfoo originalfoo mentioned this pull request Mar 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kianzarrin kianzarrin kianzarrin approved these changes

@originalfoo originalfoo originalfoo approved these changes

@kvakvs kvakvs Awaiting requested review from kvakvs

Assignees

@krzychu124 krzychu124

Labels
Asset Editor Issue related to TM:PE support in content editors BUG Defect detected confirmed Represents confirmed issue or bug Toolbar The main TMPE toolbar UI User interface updates
Projects
None yet
Milestone
11.6.5.1
Development

Successfully merging this pull request may close these issues.

Background textures missing in Scenario Editor (and others?) Blank TM:PE toolbar buttons in Scenario Editor
3 participants
@krzychu124 @originalfoo @kianzarrin